Iruleuri.tcl update to URI::compare, URI::encode and URI::decode #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 5, 2018 15:33
Update to 1.0.11
Update to `URI::encode` and `URI::decode` to use string map. `URI::encode` has been added to `%7E` / `~` excluding letter, number and some select symbols. `URI::decode` decodes all characters up to `%7E` / `~`
|
Nice work, @apextc ! I'll try to review and merge this within the next few days! |
andy-mcgrath
commented
Nov 9, 2018
andy-mcgrath
force-pushed
the
iruleuri
branch
from
684c64d to
49e991e
Compare
|
@landro I have an update to the URI::compare as well, do you want it added to this pull request or would you prefer me to create a new one so you can review independently? If you want to quickly take a look - apextc/TesTcl commit 'rewrite testcl::URI::compare' |
|
Same PR is Ok
Sendt fra min iPhone
… 9. nov. 2018 kl. 14:06 skrev apextc ***@***.***>:
@landro I have an update to the URI::compare as well, do you want it added to this pull request or would you prefer me to create a new one so you can review independently?
If you want to quickly take a look - apextc/TesTcl commit 'rewrite testcl::URI::compare'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
andy-mcgrath
changed the title
|
Great work @apextc ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to
URI::encodeandURI::decodeto use string map.URI::encodehas been added to%7e/~excluding letter, number and some select symbols.URI::decodedecodes all characters up to%7e/~and string map used to map both upper and lower case charaters.e.g.
%2band%2Bmap to+usingstring map {"%2b" "+" "%2B" "+"}Reference using UTF-8 from HTML URL Encoding Reference