URI:: support #50
Merged
URI:: support #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is consistent with the F5 behavior
#embarrassing
So that URI::host matches withouth a path and URI::protocol matches uppercase
|
Great stuff. I'll have a look at this within the next few days. |
|
Great work @magnuswatn. For future contributions, please add unit tests (I've added for the methods you hav contributed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added support for the remaining URI:: commands. Some of my implementations differ from F5s in some weird edge cases, but I'm thinking it should be good enough. I also updated URI::encode with some chars (but it's still not complete).
And while I was at it I also added a default log level, just as the F5 has.