Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MariaDB versions #56

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

todeveni
Copy link
Contributor

@todeveni todeveni commented May 23, 2024

Fixes #55

Bare minimum self-checks

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented May 23, 2024

👷 Deploy request for lando-mariadb pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6c7b09f

builders/mariadb.js Outdated Show resolved Hide resolved
@reynoldsalec reynoldsalec requested a review from uberhacker June 11, 2024 19:21
Copy link
Collaborator

@uberhacker uberhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The important thing to note here is the mariadb command was introduced in 10.4 so any earlier versions must use the mysql command.

@reynoldsalec reynoldsalec merged commit 223a531 into lando:main Jun 11, 2024
21 checks passed
@stephen-cox
Copy link

stephen-cox commented Jun 27, 2024

It's great to see a fix for #55 - is there a timeline for a new release which include this?

@reynoldsalec
Copy link
Member

Just released a new MariaDB with a few other fixes @stephen-cox. https://github.com/lando/mariadb/releases/tag/v1.4.0

Going to need to update that service across recipes as well.

@todeveni todeveni deleted the bump-mariadb-versions branch September 25, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump all MariaDB versions to latest
4 participants