Move from_read() and from_write() into AccessFs #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The from_read() and from_write() methods make sense for AccessFs but not for the upcoming AccessNet. This is a breaking change because the Access trait's signature is modified. In practice, it should not be an issue for most users. Only those implementing helpers explicitly using Access::from_read() or Access::from_write() should be concerned. In this case, they should just use AccessFs instead. Fix a typo in the from_all() comment. Signed-off-by: Mickaël Salaün <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The from_read() and from_write() methods make sense for AccessFs but not for the upcomming AccessNet: #55
This is a breaking change because the Access trait's signature is modified. In practice, it should not be an issue for most users. Only those implementing helpers explicitly using Access::from_read() or Access::from_write() should be concerned. In this case, they should just use AccessFs instead.