-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proc macros for compile time parsing #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has all the fundamental building blocks in place. A lot more work is needed, but it appears to be moving in the correct direction.
Pulldown is the only backend used by macro crate
Ideally the macros should be exported through the egui_commonmark as that would allow egui_commonmark to also reexport the code that the generated code depends on. The code can't stay in egui_commonmark as that would cause a cyclic dependency.
Added back Alert and AlertBundle. Hid implementation details that should not be exposed
egui_commonmark_backend gives more information about it's purpose
It would unnecessarily insert two extra ui.end_row() at the end of tables.
To figure out quirks about releasing two new crates and check if everything is working correctly.
Forgot to remove them after a massive refactor
This is the correct function to call
Macros had to use a separate impl so there is no reason for this to be in the backend crate when only egui_commonmark uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #49
Example
Generates the following