Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process the subsequent tasks after receiving an exception #42

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

lamnhan066
Copy link
Owner

@lamnhan066 lamnhan066 commented Dec 18, 2024

Fixes #41

There is a missing call to execute the next queued computation when receiving an exception, so the isolate will be halted if all isolates receive the exceptions at the same time.

It will work properly if there is at least one isolate that return a normal value.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.08%. Comparing base (61fa98d) to head (03694f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   91.36%   91.08%   -0.28%     
==========================================
  Files          29       29              
  Lines         695      707      +12     
==========================================
+ Hits          635      644       +9     
- Misses         60       63       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lamnhan066 lamnhan066 merged commit 08ab917 into main Dec 26, 2024
2 of 3 checks passed
@lamnhan066 lamnhan066 deleted the handle-exceptions branch December 26, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsolateManager Does Not Properly Handle Exceptions: Subsequent Tasks Are Not Processed
1 participant