Provide PHP 8.0 support

[fezfez]

• Modify composer.json to provide support for PHP 8.0 by adding the constraint ~8.0.0
• Modify composer.json to drop support for PHP less than 7.3
• Modify composer.json to implement phpunit 9.3 which supports PHP 7.3+
• Modify .travis.yml to ignore platform requirements when installing composer dependencies (simply add --ignore-platform-reqs to COMPOSER_ARGS env variable)
• Modify .travis.yml to add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)
• Modify source code in case there are incompatibilities with PHP 8.0

I have also moved to "laminas/laminas-coding-standard": "~2.1.0"

tests are working in php 8 with --ignore-platform-reqs

[fezfez]

Note : i think the ci with travis ci is deprecated and laminas org is moving to github action.
i can directly move to github action in this PR if there is a guide to migrate

[fezfez]

next will be to drop laminas/console before release ?

[fezfez]

@weierophinney ping 😃

[froschdesign]

@fezfez

i can directly move to github action in this PR if there is a guide to migrate

A separate pull request is easier to review. All required steps can be found in this pull request: laminas/laminas-server#26

Thanks in advance! 👍

[fezfez]

@froschdesign : see #19

[FabianKoestring]

Are there any changes to be made here?

[froschdesign]

@FabianKoestring
Please have a look at #19. Some help is needed there. Add your ideas or a review.
Thanks in advance! 👍

[FabianKoestring]

@FabianKoestring
Please have a look at #19. Some help is needed there. Add your ideas or a review.
Thanks in advance! 👍

Looks like PR (#28) is ready .

[fezfez]

@Xerkus : this PR seem ok to me, the psalm job fail but is also fail in 3.5.X and this is not related to this PR..

[Xerkus]

Oof. Psalm merge did not go as planned.

[Xerkus]

@fezfez lock file should be made on/for php 7.4
Looks like you did it on different version which is what causes phpcs and psalm to fail

[Xerkus]

Dropping laminas-console would require a major release.
This is not a production code, so we can potentially drop it from dependenecies and move to suggests. But it is not a route I personally would take.

[fezfez]

Dropping laminas-console would require a major release.
This is not a production code, so we can potentially drop it from dependenecies and move to suggests. But it is not a route I personally would take.

Yeah, i think it's a non sens to add PHP 8 support without dropping laminas-console, i've droped it in last commit but this PR would require a major version.

[Xerkus]

@fezfez what we will have to do is split this into two parts. Pull everything else, except for enabling php 8, into a separate PR for 3.5. php 8 + dropped console would then target 4.0

[fezfez]

@Xerkus :

@fezfez what we will have to do is split this into two parts. Pull everything else, except for enabling php 8, into a separate PR for 3.5. php 8 + dropped console would then target 4.0

it's done :)

[Xerkus]

Drop 8.0 in this PR as well, since it is not installable with laminas-console

That won't matter for composer but It will make clear for users that they need to upgrade to 4.0 for php 8

[fezfez]

I think the same strategy than laminas-cache can be used in this case. example

in composer.json

    "replace": {
        "llaminas/laminas-console": "*"
    }

in this way, 3.5.x can be use with php 8, dont you think it wort it ?

Edit: never mind, it cant work because the autoload will break...

[Xerkus]

I do not see a value in this. It is a dev dependency kind of package. Something else depending on it is quite unlikely.

[Xerkus]

@fezfez are you in our slack? I would like to request some chores for 3.5 before we move on to 4,0

[weierophinney]

🚢