-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GHA CI workflow #18
Add GHA CI workflow #18
Conversation
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
@internalsystemerror Could you please fix the DCO as detailed here? Thanks in advance. |
Signed-off-by: Gary Lockett <[email protected]>
@boesing, sorry thought I already did. Done now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One thing: Could you drop support for PHP prior 7.3?
Laminas is okay with dropping PHP support in minor versions.
There is one thing we do want to ensure:
If a PHP version is supported by this package and by https://www.php.net/supported-versions.php, we have to keep it supported.
Thats why we do not drop support for PHP 7.3 until 6 Dec 2021.
.laminas-ci.json
Outdated
@@ -0,0 +1,6 @@ | |||
{ | |||
"exclude": [ | |||
{"name": "PHPUnit on PHP 7.1 with locked dependencies"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer having support for PHP 7.1 just dropped here.
We can have ^7.3
in composer.json
to avoid this whole file.
The composer.lock
then should be created with PHP 7.3.
Signed-off-by: Gary Lockett <[email protected]>
Thanks, @internalsystemerror |
This PR adds GitHub Actions for this repository as per https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4.
The following actions were performed:
remove changelog
add github workflow file
remove travis workflow
remove composer.lock from gitignore
remove travis from gitattributes
add composer.lock file updated on PHP 7.4
exclude locked runs for PHP <7.3