Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA CI workflow #18

Merged
merged 4 commits into from
Apr 8, 2021
Merged

Add GHA CI workflow #18

merged 4 commits into from
Apr 8, 2021

Conversation

internalsystemerror
Copy link
Member

This PR adds GitHub Actions for this repository as per https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4.

The following actions were performed:

remove changelog
add github workflow file
remove travis workflow
remove composer.lock from gitignore
remove travis from gitattributes
add composer.lock file updated on PHP 7.4
exclude locked runs for PHP <7.3

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Gary Lockett added 2 commits April 5, 2021 17:12
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
@boesing
Copy link
Member

boesing commented Apr 8, 2021

@internalsystemerror Could you please fix the DCO as detailed here?
https://github.com/laminas/laminas-permissions-rbac/pull/18/checks?check_run_id=2280478933

Thanks in advance.

@boesing boesing mentioned this pull request Apr 8, 2021
6 tasks
Signed-off-by: Gary Lockett <[email protected]>
@internalsystemerror
Copy link
Member Author

@boesing, sorry thought I already did. Done now

Copy link
Member

@boesing boesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One thing: Could you drop support for PHP prior 7.3?
Laminas is okay with dropping PHP support in minor versions.
There is one thing we do want to ensure:

If a PHP version is supported by this package and by https://www.php.net/supported-versions.php, we have to keep it supported.

Thats why we do not drop support for PHP 7.3 until 6 Dec 2021.

.laminas-ci.json Outdated
@@ -0,0 +1,6 @@
{
"exclude": [
{"name": "PHPUnit on PHP 7.1 with locked dependencies"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer having support for PHP 7.1 just dropped here.
We can have ^7.3 in composer.json to avoid this whole file.

The composer.lock then should be created with PHP 7.3.

@boesing boesing added this to the 3.1.0 milestone Apr 8, 2021
Signed-off-by: Gary Lockett <[email protected]>
@boesing boesing merged commit 5bfa4e3 into laminas:3.1.x Apr 8, 2021
@boesing
Copy link
Member

boesing commented Apr 8, 2021

Thanks, @internalsystemerror

This was referenced Apr 8, 2021
@internalsystemerror internalsystemerror deleted the feature/gha-workflow branch April 8, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants