PHP 8.0 support #12 #14

gpgkd906 · 2021-03-03T08:18:26Z

Q	A
New Feature	yes

Description

Modify composer.json to provide support for PHP 8.0 by adding the constraint ~8.0.0
Modify composer.json to drop support for PHP less than 7.3
Modify composer.json to implement phpunit 9.3 which supports PHP 7.3+
Modify .travis.yml to ignore platform requirements when installing composer dependencies (simply add --ignore-platform-[x] reqs to COMPOSER_ARGS env variable)
Modify .travis.yml to add PHP 8.0 to the matrix (NOTE: Do not allow failures as PHP 8.0 has a feature freeze since 2020-08-04!)
Modify source code in case there are incompatibilities with PHP 8.0

Signed-off-by: chenhan <[email protected]>

gennadiylitvinyuk

Please remove .phpunit,results.cache from Pull-Request.

Travis CI is gone and the new workflow for continuous integration must be added that the tests can be run. (See also on other components for help, e.g. laminas-feed.)

gennadiylitvinyuk · 2021-04-03T13:31:38Z

.phpunit.result.cache

@@ -0,0 +1 @@
+C:37:"PHPUnit\Runner\DefaultTestResultCache":2827:{a:2:{s:7:"defects";a:1:{s:94:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testCallbackIsDecoratedAsClosure";i:4;}s:5:"times";a:35:{s:94:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testCallbackIsDecoratedAsClosure";d:0.02;s:96:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertMethodPassRbacToCallback";d:0.002;s:78:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertMethod";d:0.001;s:84:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertWithCallable";d:0;s:88:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertWithInvalidValue";d:0.004;s:61:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedAssertion";d:0.003;s:62:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedSingleRole";d:0;s:62:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedChildRoles";d:0;s:67:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedWithInvalidRole";d:0;s:50:"LaminasTest\Permissions\Rbac\RbacTest::testGetRole";d:0;s:50:"LaminasTest\Permissions\Rbac\RbacTest::testHasRole";d:0.002;s:68:"LaminasTest\Permissions\Rbac\RbacTest::testHasRoleWithInvalidElement";d:0;s:59:"LaminasTest\Permissions\Rbac\RbacTest::testGetUndefinedRole";d:0;s:60:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleFromString";d:0;s:59:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleFromClass";d:0;s:58:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleNotValid";d:0;s:70:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleWithParentsUsingRbac";d:0;s:79:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleWithAutomaticParentsUsingRbac";d:0;s:61:"LaminasTest\Permissions\Rbac\RbacTest::testAddCustomChildRole";d:0.048;s:64:"LaminasTest\Permissions\Rbac\RbacTest::testAddMultipleParentRole";d:0.001;s:56:"LaminasTest\Permissions\Rbac\RbacTest::testAddParentRole";d:0;s:51:"LaminasTest\Permissions\Rbac\RbacTest::testGetRoles";d:0;s:53:"LaminasTest\Permissions\Rbac\RbacTest::testEmptyRoles";d:0;s:54:"LaminasTest\Permissions\Rbac\RoleTest::testConstructor";d:0;s:50:"LaminasTest\Permissions\Rbac\RoleTest::testGetName";d:0;s:56:"LaminasTest\Permissions\Rbac\RoleTest::testAddPermission";d:0;s:60:"LaminasTest\Permissions\Rbac\RoleTest::testInvalidPermission";d:0;s:51:"LaminasTest\Permissions\Rbac\RoleTest::testAddChild";d:0;s:52:"LaminasTest\Permissions\Rbac\RoleTest::testAddParent";d:0;s:62:"LaminasTest\Permissions\Rbac\RoleTest::testPermissionHierarchy";d:0;s:67:"LaminasTest\Permissions\Rbac\RoleTest::testCircleReferenceWithChild";d:0.002;s:68:"LaminasTest\Permissions\Rbac\RoleTest::testCircleReferenceWithParent";d:0;s:57:"LaminasTest\Permissions\Rbac\RoleTest::testGetPermissions";d:0;s:58:"LaminasTest\Permissions\Rbac\RoleTest::testAddTwoChildRole";d:0;s:56:"LaminasTest\Permissions\Rbac\RoleTest::testAddSameParent";d:0;}}}


Should be excluded from Repo through .gitignore

thanks, I will delete this file and add in .gitignore

gennadiylitvinyuk · 2021-04-03T13:34:43Z

.travis.yml

    - php: 7.3
      env:
        - DEPS=lowest
-    - php: 7.3
+    - php: 8.0


Actually this file should be deleted too, but it is still in instructions.

Why did you replace PHP 7.4 instead of adding 8.0?

Sorry for this one...
I checked other component's Pull-Request to learn what should i do, for example: laminas-di

Actually this file should be deleted too, but it is still in instructions.

I will delete this file.

gennadiylitvinyuk · 2021-04-03T15:35:57Z

Just for linking - should implement #12

Signed-off-by: 陈瀚 <[email protected]>

boesing · 2021-04-08T10:10:02Z

Closing this in favor of #20

PHP 8.0 support laminas#12

1d57cd2

Signed-off-by: chenhan <[email protected]>

gennadiylitvinyuk suggested changes Apr 3, 2021

View reviewed changes

gpgkd906 added 3 commits April 8, 2021 14:00

PHP 8.0 support laminas#12

ccc0517

Signed-off-by: 陈瀚 <[email protected]>

PHP 8.0 support laminas#12 add continuous-integration.yml

c5241ee

Signed-off-by: 陈瀚 <[email protected]>

PHP 8.0 support laminas#12 add newline

62bd09b

Signed-off-by: 陈瀚 <[email protected]>

boesing closed this Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.0 support #12 #14

PHP 8.0 support #12 #14

gpgkd906 commented Mar 3, 2021

gennadiylitvinyuk left a comment

gennadiylitvinyuk Apr 3, 2021

gpgkd906 Apr 8, 2021

gennadiylitvinyuk Apr 3, 2021

gpgkd906 Apr 8, 2021 •

edited

Loading

gennadiylitvinyuk commented Apr 3, 2021

boesing commented Apr 8, 2021

		@@ -0,0 +1 @@
		C:37:"PHPUnit\Runner\DefaultTestResultCache":2827:{a:2:{s:7:"defects";a:1:{s:94:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testCallbackIsDecoratedAsClosure";i:4;}s:5:"times";a:35:{s:94:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testCallbackIsDecoratedAsClosure";d:0.02;s:96:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertMethodPassRbacToCallback";d:0.002;s:78:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertMethod";d:0.001;s:84:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertWithCallable";d:0;s:88:"LaminasTest\Permissions\Rbac\Assertion\CallbackAssertionTest::testAssertWithInvalidValue";d:0.004;s:61:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedAssertion";d:0.003;s:62:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedSingleRole";d:0;s:62:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedChildRoles";d:0;s:67:"LaminasTest\Permissions\Rbac\RbacTest::testIsGrantedWithInvalidRole";d:0;s:50:"LaminasTest\Permissions\Rbac\RbacTest::testGetRole";d:0;s:50:"LaminasTest\Permissions\Rbac\RbacTest::testHasRole";d:0.002;s:68:"LaminasTest\Permissions\Rbac\RbacTest::testHasRoleWithInvalidElement";d:0;s:59:"LaminasTest\Permissions\Rbac\RbacTest::testGetUndefinedRole";d:0;s:60:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleFromString";d:0;s:59:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleFromClass";d:0;s:58:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleNotValid";d:0;s:70:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleWithParentsUsingRbac";d:0;s:79:"LaminasTest\Permissions\Rbac\RbacTest::testAddRoleWithAutomaticParentsUsingRbac";d:0;s:61:"LaminasTest\Permissions\Rbac\RbacTest::testAddCustomChildRole";d:0.048;s:64:"LaminasTest\Permissions\Rbac\RbacTest::testAddMultipleParentRole";d:0.001;s:56:"LaminasTest\Permissions\Rbac\RbacTest::testAddParentRole";d:0;s:51:"LaminasTest\Permissions\Rbac\RbacTest::testGetRoles";d:0;s:53:"LaminasTest\Permissions\Rbac\RbacTest::testEmptyRoles";d:0;s:54:"LaminasTest\Permissions\Rbac\RoleTest::testConstructor";d:0;s:50:"LaminasTest\Permissions\Rbac\RoleTest::testGetName";d:0;s:56:"LaminasTest\Permissions\Rbac\RoleTest::testAddPermission";d:0;s:60:"LaminasTest\Permissions\Rbac\RoleTest::testInvalidPermission";d:0;s:51:"LaminasTest\Permissions\Rbac\RoleTest::testAddChild";d:0;s:52:"LaminasTest\Permissions\Rbac\RoleTest::testAddParent";d:0;s:62:"LaminasTest\Permissions\Rbac\RoleTest::testPermissionHierarchy";d:0;s:67:"LaminasTest\Permissions\Rbac\RoleTest::testCircleReferenceWithChild";d:0.002;s:68:"LaminasTest\Permissions\Rbac\RoleTest::testCircleReferenceWithParent";d:0;s:57:"LaminasTest\Permissions\Rbac\RoleTest::testGetPermissions";d:0;s:58:"LaminasTest\Permissions\Rbac\RoleTest::testAddTwoChildRole";d:0;s:56:"LaminasTest\Permissions\Rbac\RoleTest::testAddSameParent";d:0;}}}

PHP 8.0 support #12 #14

PHP 8.0 support #12 #14

Conversation

gpgkd906 commented Mar 3, 2021

Description

gennadiylitvinyuk left a comment

Choose a reason for hiding this comment

gennadiylitvinyuk Apr 3, 2021

Choose a reason for hiding this comment

gpgkd906 Apr 8, 2021

Choose a reason for hiding this comment

gennadiylitvinyuk Apr 3, 2021

Choose a reason for hiding this comment

gpgkd906 Apr 8, 2021 • edited Loading

Choose a reason for hiding this comment

gennadiylitvinyuk commented Apr 3, 2021

boesing commented Apr 8, 2021

gpgkd906 Apr 8, 2021 •

edited

Loading