Add ControllerManager::class as resolvable service
#96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rManager' to an alias Signed-off-by: Thomas Rieschl <[email protected]>
|
Would it be okay if I clean up the |
IMO separate patch - this one is a feature addition, let's make the next bit independently reviewable |
|
I'm not sure, but I think this should be a minor release? But there's no |
Ocramius
changed the title
ControllerManager::class as resolvable service
|
@rieschl oof, indeed, branches being a mess again -.- |
|
Slipped into |
This was referenced Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discovered in Slack, it is not possible to get the ControllerManager via its FQCN.
This PR adds the FQCN as canonical name of the service and changes the
'ControllerManager'service to an alias.