Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and clarify routing in quick start; remove default route #94

Merged
merged 3 commits into from
Jan 26, 2022

Conversation

afilina
Copy link
Contributor

@afilina afilina commented Jan 26, 2022

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

  • The default route is no longer a thing.
  • Remove redundant code example, since the example below already combines the route and controller.
  • "Now that we have" filler sentence that also assumes the reader read everything that came before.
  • Explained how routes work on the most basic level.
  • Use comments in the code example to identify key parts and how they're used.
  • Change controller name to hello-controller, because the previous name was similar to the class name. It could have caused mistakes for less attentive devs. It also helps to know that this is just an arbitrary string, not some class name.
  • Give a summary of the execution flow at the end.
  • Add a link to routing page.
  • Drop the "Controller services" section. It reads too much like internals docs. In any case, it seemed unnecessary in the quick start.

afilina and others added 2 commits January 26, 2022 10:29
Co-authored-by: Frank Brückner <[email protected]>
Signed-off-by: Anna Filina <[email protected]>
@weierophinney weierophinney added this to the 3.3.1 milestone Jan 26, 2022
@weierophinney weierophinney merged commit 7d11bcc into laminas:3.3.x Jan 26, 2022
@afilina afilina deleted the quick-start-routing branch January 27, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants