Drop obsolete cookbook for middleware in listeners #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei <[email protected]>
Xerkus
force-pushed
the
docs/drop-middleware-in-listeners
branch
from
a65e9c9 to
ebd7c16
Compare
|
I think it's absolutely fine to remove it completely. The variant should also not be used in older versions. |
froschdesign
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Middleware in listeners cookbook was obsoleted by later interop changes and not compatible with psr middleware.
It relied heavily on the fact that middleware accepted request and response object while it was not required to return a response.