Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Laminas GHA CI Workflow #8

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Adds Laminas GHA CI Workflow #8

merged 1 commit into from
Apr 2, 2021

Conversation

froschdesign
Copy link
Member

@froschdesign froschdesign commented Apr 1, 2021 •
edited
Loading

@froschdesign froschdesign added this to the 1.2.0 milestone Apr 1, 2021
@boesing boesing mentioned this pull request Apr 2, 2021
Merged
@boesing
Copy link
Member

boesing commented Apr 2, 2021

@froschdesign imho, we can drop PHP <7.3 in here in favor of faster merging.

@froschdesign froschdesign force-pushed the feature/ci-workflow branch from 40850e6 to c3d8e22 Compare April 2, 2021 14:22
@froschdesign
Adds Laminas GHA CI Workflow
6cf91dc 
Signed-off-by: Frank Brückner <[email protected]>
@froschdesign froschdesign force-pushed the feature/ci-workflow branch from c3d8e22 to 6cf91dc Compare April 2, 2021 14:25
@froschdesign
Copy link
Member Author

@boesing

we can drop PHP <7.3 in here in favor of faster merging.

There is another pull request for it: #7

@boesing
Copy link
Member

boesing commented Apr 2, 2021

Okay, so we might want to merge this, rebase #7 and merge it, rebase #9 and we might be good to go 👍🏼

@boesing boesing merged commit 67bd4c8 into laminas:1.2.x Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boesing boesing boesing approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@froschdesign @boesing