Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DateTimeSelect #209

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Refactor DateTimeSelect #209

merged 1 commit into from
Dec 17, 2024

Conversation

ramchale
Copy link
Contributor

Q A
Documentation yes
Bugfix no
BC Break yes
New Feature no
RFC yes
QA no

Description

Refactor DateTimeSelect to be consistent with new DateSelect and MonthSelect behaviour

Signed-off-by: ramchale <[email protected]>
@froschdesign froschdesign added this to the 3.0.0 milestone Dec 17, 2024
@froschdesign froschdesign requested a review from gsteel December 17, 2024 12:38
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement. Thanks @ramchale :)

@gsteel gsteel self-assigned this Dec 17, 2024
@gsteel gsteel merged commit 0a44105 into laminas:3.0.x Dec 17, 2024
16 of 17 checks passed
@gsteel gsteel mentioned this pull request Dec 17, 2024
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants