Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DateTimeFormatter Filter #160

Merged
merged 11 commits into from
Sep 3, 2024
Merged

Refactor DateTimeFormatter Filter #160

merged 11 commits into from
Sep 3, 2024

Conversation

pinclau
Copy link
Contributor

@pinclau pinclau commented Aug 16, 2024

Q A
Documentation yes
BC Break yes
QA yes

Description

  • Drops inheritage
  • Replaced deprecated format
  • Added usage documentation

gsteel
gsteel requested changes Aug 16, 2024
View reviewed changes
@gsteel gsteel added this to the 3.0.0 milestone Aug 16, 2024
pinclau added 2 commits August 21, 2024 17:12
@pinclau
changes from review for refactor
4dfa7d1 
Signed-off-by: Claudiu Pintiuta <[email protected]>
@pinclau
changes from review for refactor
78ef234 
Signed-off-by: Claudiu Pintiuta <[email protected]>
@pinclau
Copy link
Contributor Author

pinclau commented Aug 21, 2024

@gsteel thank you for the review, the latest pull request should reflect the changes from your review with some changes that you should review if they are ok or what need to be changed, more specific the timezone support and the filter method that now did not return any value that cannot be converted to a DateTimeImmutable and will throw an exception.

gsteel
gsteel requested changes Aug 21, 2024
View reviewed changes
@gsteel gsteel requested a review from froschdesign August 21, 2024 15:04
gsteel
gsteel requested changes Aug 21, 2024
View reviewed changes
froschdesign
froschdesign requested changes Aug 21, 2024
View reviewed changes
pinclau added 2 commits August 23, 2024 16:25
@pinclau
changes from review
5f98135 
Signed-off-by: Claudiu Pintiuta <[email protected]>
@pinclau
typo and tests fix
556b0f3 
Signed-off-by: Claudiu Pintiuta <[email protected]>
gsteel
gsteel requested changes Aug 23, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more tweaks!

@pinclau
changes from review
417a5d1 
Signed-off-by: Claudiu Pintiuta <[email protected]>
@pinclau pinclau requested a review from gsteel September 3, 2024 09:29
gsteel
gsteel approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cPintiuta, LGTM 👍

@gsteel gsteel self-assigned this Sep 3, 2024
@gsteel gsteel linked an issue Sep 3, 2024 that may be closed by this pull request
Is DateTimeFormatter filter missed in documentation? #44
Closed
@gsteel gsteel merged commit e288198 into laminas:3.0.x Sep 3, 2024
14 of 15 checks passed
This was referenced Sep 3, 2024
Closed
Closed
@froschdesign froschdesign mentioned this pull request Sep 3, 2024
Closed
@gsteel gsteel mentioned this pull request Sep 8, 2024
Open
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boesing boesing boesing left review comments

@froschdesign froschdesign froschdesign requested changes

@gsteel gsteel gsteel approved these changes

Assignees

@gsteel gsteel

Labels
BC Break Documentation Enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Is DateTimeFormatter filter missed in documentation?
4 participants
@pinclau @froschdesign @boesing @gsteel