Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Drop Support for PHP 8.1 in v3.0 #145

Closed
wants to merge 1 commit into from

Conversation

gsteel
Copy link
Member

@gsteel gsteel commented Jun 13, 2024

Dropping support for 8.1 will open the door to readonly classes (Yay!) and allow upgrade to PHPUnit 11 (Sort of Yay!)

Any objections?

Signed-off-by: George Steel <[email protected]>
@gsteel gsteel added this to the 3.0.0 milestone Jun 13, 2024
@gsteel gsteel requested a review from a team June 13, 2024 14:26
@gsteel gsteel changed the title [RFC] Drop Support for PHP 8.1 [RFC] Drop Support for PHP 8.1 in v3.0 Jun 13, 2024
@weierophinney
Copy link
Member

I'd rather see this as part of a PR that actually incorporates readonly, as then the justification becomes more clear. But no objections, particularly if it allows us to ship something more resilient and predictable!

@gsteel
Copy link
Member Author

gsteel commented Jun 13, 2024

I'd rather see this as part of a PR that actually incorporates readonly, as then the justification becomes more clear. But no objections, particularly if it allows us to ship something more resilient and predictable!

I've just upgraded to SMv4 here and I'm about to refactor most of the filters to be final readonly class SomeFilter implements FilterInterface {} but I'll likely do it in smaller PRs to make review easier.

If you could take a look at #118 and imagine the class is also readonly there 🙏

@boesing
Copy link
Member

boesing commented Jun 13, 2024

Having readonly classes vs readonly properties makes no difference besides syntax sugar.
If you just need readonly feature, go ahead and introduce readonly properties instead.
I personally do not like dropping PHP versions without good reasons, so there would be a "no" from me.

@gsteel
Copy link
Member Author

gsteel commented Jun 13, 2024

@boesing Fair point well made… Considering the new maintenance windows for PHP it might also be a bit premature too.

@gsteel gsteel added Won't Fix This will not be worked on and removed Enhancement labels Jun 14, 2024
@gsteel gsteel closed this Jun 14, 2024
@gsteel gsteel deleted the v3/drop-8.1 branch June 14, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Won't Fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants