Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize composer #85

Merged
merged 3 commits into from
May 21, 2021
Merged

Normalize composer #85

merged 3 commits into from
May 21, 2021

Conversation

ghostwriter
Copy link
Contributor

[QA]

  • Normalize composer.json and/or update composer.lock
    • Restructure composer.json according to the underlying JSON schema.
    • Prevent inconsistencies between all (200+) repositories across all 3 GitHub organizations (laminas, mezzio, and laminas-api-tools).

@ghostwriter
Normalize composer.json
eab892c 
Signed-off-by: Nathanael Esayeas <[email protected]>
@ghostwriter
Update composer.lock
bb484e4 
Signed-off-by: Nathanael Esayeas <[email protected]>
@Ocramius
Copy link
Member

Looks like composer.lock was updated without considering the fact that we need to operate under the constraints of our CI setup: need to close this therefore.

Please consider re-opening if you want to run a composer update nothing instead.

@Ocramius Ocramius closed this May 19, 2021
@Ocramius Ocramius self-assigned this May 19, 2021
@Ocramius Ocramius added Enhancement Invalid This doesn't seem right labels May 19, 2021
@ghostwriter
Copy link
Contributor Author

okay, re-open it. I'll correct the PR.

@Ocramius Ocramius reopened this May 19, 2021
@Ocramius Ocramius removed the Invalid This doesn't seem right label May 19, 2021
@ghostwriter
Revert "Update composer.lock"
9dd6af4 
This reverts commit bb484e4.

Signed-off-by: Nathanael Esayeas <[email protected]>
@Ocramius
Copy link
Member

Excellent, thanks!

@Ocramius Ocramius added this to the 4.4.0 milestone May 21, 2021
@Ocramius Ocramius changed the base branch from 4.3.x to 4.4.x May 21, 2021 08:54
@Ocramius Ocramius merged commit 55c34ea into laminas:4.4.x May 21, 2021
@ghostwriter ghostwriter deleted the feature/qa-composer-normalize branch May 21, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostwriter @Ocramius