PHP 8.3 support added #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,6 @@ | |||
| "gd" | |||
| ], | |||
| "ignore_php_platform_requirements": { | |||
| "8.2": true | |||
| "8.3": true | |||
There was a problem hiding this comment.
@gsteel
Do we really need this here?
There was a problem hiding this comment.
Generally, it should required, any concern pls let me know
There was a problem hiding this comment.
@froschdesign
Yes, platform reqs will have to be ignored until all composer deps explicitly support 8.3 - ideally we would get 8.3 supported on all the deps first to avoid it.
|
@froschdesign Can you please proceed for merge this PR if you are not having any concern? |
Ocramius
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description