Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated require section #19

Closed

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Apr 6, 2022

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA yes

Description

Added require dependencies (laminas/laminas-recaptcha, laminas/laminas-session, laminas/laminas-text, laminas/laminas-validator) to require section to fix the following issues:
Fixes #18
Fixes #16

…s-session, laminas/laminas-text, laminas/laminas-validator) to require section

Signed-off-by: Sergiy Vasiutynskyi <[email protected]>
@sergiy-v sergiy-v force-pushed the 2.11.x-fix-composer-require branch from b91a3dd to 0f93375 Compare April 6, 2022 11:18
@Ocramius Ocramius modified the milestones: 2.11.1, 2.12.0 Apr 6, 2022
@Ocramius Ocramius added Bug Something isn't working Enhancement labels Apr 6, 2022
@Ocramius Ocramius changed the base branch from 2.11.x to 2.12.x April 6, 2022 11:35
@sergiy-v
Copy link
Contributor Author

sergiy-v commented Apr 6, 2022

@Ocramius hello)
Since we have conflict here I would like to clarify - would you like to have the working branch updated to 2.12.x or should I create a new PR?
I could update the working branch but name starting with 2.11.x with code for 2.12.x may confuse a bit, so it's fine for me to create a new PR.
Please clarify.

@Ocramius
Copy link
Member

Ocramius commented Apr 6, 2022

Hey @sergiy-v, a couple things:

  1. 2.11.x should not receive dependency changes: the reason being that patch releases should always allow for easy upgrades, since they may be security issues. In an x.y.z versioning scheme, never change dependencies in a z version
  2. It may be worth taking your composer.json changes, applying them to 2.12.x, updating composer.lock accordingly, then committing and force-pushing to this branch.

If you prefer to do a new PR, that is fine too :)

@sergiy-v
Copy link
Contributor Author

sergiy-v commented Apr 7, 2022

Hey @sergiy-v, a couple things:

  1. 2.11.x should not receive dependency changes: the reason being that patch releases should always allow for easy upgrades, since they may be security issues. In an x.y.z versioning scheme, never change dependencies in a z version
  2. It may be worth taking your composer.json changes, applying them to 2.12.x, updating composer.lock accordingly, then committing and force-pushing to this branch.

If you prefer to do a new PR, that is fine too :)

@Ocramius thank you for the details. Sorry, I totally missed point 1.
I have created a new PR for the changes, so closing this one.

@sergiy-v sergiy-v closed this Apr 7, 2022
@sergiy-v sergiy-v deleted the 2.11.x-fix-composer-require branch April 7, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "require" section must be updated error Class 'Laminas\Validator\AbstractValidator' not found
2 participants