Revert "Avoid circular dependency in nerdfont#find"

[lambdalisue]

This reverts commit 0b21e3f.

It breaks thirdparty plugins.

Summary by CodeRabbit

• New Features

  • Simplified handling of the default Nerd Font variable for improved performance.
  • Initialization of the default variable now occurs globally for better management.

• Bug Fixes

  • Enhanced reliability of the nerdfont#find function by removing unnecessary conditional checks.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request focus on the autoload/nerdfont.vim file, specifically modifying the nerdfont#find function and the management of the global variable g:nerdfont#default. The conditional logic for returning g:nerdfont#default has been simplified by removing the previous checks. A new initialization line for g:nerdfont#default has been added to set its value from g: or default to a specific path if not already defined. The s:autofix function remains unchanged.

Changes

File	Change Summary
autoload/nerdfont.vim	- Simplified return statement in nerdfont#find function. - Added initialization for g:nerdfont#default. - No changes to nerdfont#get_json and s:autofix functions.

Possibly related PRs

• Fix CI and upgrade supported Vim version #34: The changes in autoload/nerdfont.vim regarding the nerdfont#find function and the handling of the g:nerdfont#default variable may relate to the overall improvements in the plugin's functionality, which could be indirectly affected by CI upgrades and testing across different Vim versions.

Poem

🐰 In the code where fonts do play,
A simpler path has found its way.
With defaults set, no need to fret,
A cleaner flow, we won't forget!
Hopping through changes, oh what a sight,
Nerdy fonts, now shining bright! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.