forked from matter-labs/zksync-era
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eigenDA proxy to docker #258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Details:
|
juan518munoz
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
juan518munoz
pushed a commit
that referenced
this pull request
Sep 17, 2024
* Add proxy to docker * Add api_node_url to toml initialization * Add eigenda flag to zk server * Revert "Add eigenda flag to zk server" This reverts commit 081cff6. * Update submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds eigenDA proxy to docker initialization
Adds API_NODE_URL env variable to .toml in order to not need to run
export EIGEN_DA_CLIENT_API_NODE_URL=http://127.0.0.1:3100
Adds a
--da-eigen
flag tozkserver
, now you can runzk server --da-eigen
instead of runningcargo run --bin zksync_server --features da-eigen
, the first time you need to runIn order to re-build the zk tool (maybe you can just run
zk
, i'm not sure)Closes https://github.com/lambdaclass/hyperchain-da-eigenda/issues/2
Why ❔
Checklist
zk fmt
andzk lint
.