Compression for bls12381 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation was ported and adapted from https://github.com/lambdaclass/lambdaworks_kzg/blob/8f031b1f32e170c1af06029e46c73404f4c85e2e/src/compression.rs#L29.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 72.83% 72.75% -0.09%
==========================================
Files 150 150
Lines 34158 34196 +38
==========================================
Hits 24880 24880
- Misses 9278 9316 +38 ☔ View full report in Codecov by Sentry. |
math/src/elliptic_curve/short_weierstrass/curves/bls12_381/compression.rs
Outdated
Show resolved
Hide resolved
diegokingston
approved these changes
Sep 3, 2024
pablodeymo
reviewed
Sep 4, 2024
| @@ -18,3 +19,16 @@ pub trait IsShortWeierstrass: IsEllipticCurve + Clone + Debug { | |||
| y.pow(2_u16) - x.pow(3_u16) - Self::a() * x - Self::b() | |||
| } | |||
| } | |||
|
|
|||
| pub trait Compress { | |||
There was a problem hiding this comment.
You could add some docs here explaining what is the purpose of this trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port compression for BLS12381
Note: replaces #902
Description
Port compression for BLS12381 from lambdaworks_kzg.
The motivation for this PR is to introduce missing compression functionality for the
BLS12381Curve, specifically, decompression for G1 and G2 points.The changes included are:
Compresstrait, which defines compression and decompression for G1, and decompression for G2.Compresstrait forBLS12381Curve.Type of change
Checklist