Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker test command name #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix docker test command name #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83bfa3a
Fix docker test cmd name
gabrielbosio Jul 31, 2023
bfb7ac7
Sync cmd name in ci
gabrielbosio Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- run: make docker_build docker_test_and_format
- run: make docker_build docker_test_and_valgrind
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ docker_build:
docker_run:
docker run --rm -it -v `pwd`:/usr/cairo-vm_in_C cairo-vm_in_c

docker_test_and_format:
docker_test_and_valgrind:
docker create --name test -t -v `pwd`:/usr/cairo-vm_in_C cairo-vm_in_c
docker start test
docker exec -t test bash -c "make clean && make docker_build_collections_lib && make test && make SANITIZER_FLAGS=-fno-omit-frame-pointer docker_valgrind"
Expand Down