Switch memory inner structure to hashtable #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-runner-and-initialization
…o-runner-and-initialization
jrchatruc
reviewed
Jul 27, 2023
Comment on lines
+33
to
+36
| COLLECTIONS_LIB_DIR= Collections-C | ||
| $(COLLECTIONS_LIB_DIR): | ||
| git clone https://github.com/srdja/Collections-C.git | ||
| cd Collections-C && \ |
There was a problem hiding this comment.
This library has a bunch of dependencies that we should document and add to the README like cmake, pkg-config and cpputest that are not present by default in macOS (In general, setting up the environment to install and link to it correctly is not simple so it should be well documented)
There was a problem hiding this comment.
Another alternative: just add the targets for the object files manually, everything in there seems pretty self-contained. That would save us from having extra dev deps.
jrchatruc
approved these changes
Jul 27, 2023
gabrielbosio
approved these changes
Jul 27, 2023
Draft
Oppen
approved these changes
Jul 28, 2023
Oppen
approved these changes
Jul 28, 2023
mmsc2
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify memory operations and remove unhandled border cases by using a simpler memory structure, based on a hashmap rather than arrays within an array
This PR also:
print_memoryfor debugging/educational purposes