Removed MixinEntityLivingBase reflection hack #384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull
Removes a reflection hack done in MixinEntityLivingBase to keep compatibility with older Mixin versions.
Describe how this pull is helpful
The comment above the hack describes it as
a bit silly and bad for performance
which is fixed here.Additional context
The reason the hack was added is because Mixin did not have this line prior to 0.8. In Mixin 0.7 the check
typeInfo.isLoadable()
(which would check if AccessorEntityFireworkRocket is an Accessor) did not exist, causing Mixin to try to find the class in the hierachy of EntityLivingBase. This only happens when a Mixin method is merged into the targeted class, and only for the methods of that Mixin class, so putting the methods inside a helper class fixes the issue.Let me know if this is wanted and if the helper class should be a kotlin class instead.