Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update term and bump version #1

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

Eijebong
Copy link
Contributor

@Eijebong Eijebong commented May 7, 2018

No description provided.

@Eijebong
Copy link
Contributor Author

Eijebong commented May 7, 2018

Ping @nikomatsakis since you're not watching that repo ;)

@alekratz
Copy link

alekratz commented Apr 2, 2019

Bump - can this get merged? I need the fixed version of term that doesn't break with the *-256color terminals.

@CYBAI
Copy link

CYBAI commented Apr 27, 2019

Ping @nikomatsakis .
While trying to introduce color-backtrace to Servo at servo/servo#23239 , the test-tidy script told me we'll have different version of term that ascii-canvas is using an old one.
If this one merged, the issue will be fixed!
Could you help to merge this PR if it's ok :)? Thanks!

@nikomatsakis nikomatsakis merged commit 33e2b45 into lalrpop:master Apr 29, 2019
@nikomatsakis
Copy link
Contributor

I guess we also need to publish something ?

@Eijebong
Copy link
Contributor Author

Yeah, just need to publish ascii-canvas

@nikomatsakis
Copy link
Contributor

@Eijebong done

@Eijebong
Copy link
Contributor Author

For reference, followup for lalrpop lalrpop/lalrpop#456 @CYBAI

@bmwill bmwill mentioned this pull request Apr 29, 2019
@CYBAI
Copy link

CYBAI commented Apr 30, 2019

@nikomatsakis @Eijebong Thank you so much! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants