Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce warnings from -Weffc++ #989

Merged
merged 16 commits into from
Oct 4, 2021
Merged

Reduce warnings from -Weffc++ #989

merged 16 commits into from
Oct 4, 2021

Conversation

DanRStevens
Copy link
Collaborator

Reference: #528 (-Weffc++)

Add explicit default initialization for fields that must be default initialized. This is either because the field type has only a default constructor, or the containing type does not have any constructors taking parameters that could be used to initialize the field to anything other than the default.

This does not attempt to default initialize every field. In particular, some fields may be set by constructor parameters, or might be inappropriate to default initialize. In particular, we don't want to silence warnings for a field that is not properly initialized by a constructor, when that field is required to be explicitly initialized by all constructors.

@DanRStevens DanRStevens merged commit 0bdbd8b into master Oct 4, 2021
@DanRStevens DanRStevens deleted the warnEffCpp branch October 4, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant