Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnimationSet warning #1003

Merged
merged 2 commits into from
Nov 28, 2021
Merged

Fix AnimationSet warning #1003

merged 2 commits into from
Nov 28, 2021

Conversation

DanRStevens
Copy link
Collaborator

Closes #962

Convert factory function to tuple of components.

We basically need a tempory to hold the result of the function call, and
then split it up into member fields. There's no way to assign and use
such a tempory in the init list. Without the temporary, you'd need to
call the helper function multiple times, once for each field being
assigned. Probably best to just use the constructor body here.

Not using the init list does lead to some double init of member fields.
The impact of initialing an empty `std::map` and then assigning to it
right after should be fairly minimal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AnimationSet C26495 warning
1 participant