Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make album photo clickable #142

Closed
gammaw opened this issue Nov 16, 2019 · 6 comments
Closed

Make album photo clickable #142

gammaw opened this issue Nov 16, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@gammaw
Copy link
Member

gammaw commented Nov 16, 2019

Currently, only text is clickable.

@gammaw gammaw added the enhancement New feature or request label Nov 16, 2019
@baxgas
Copy link
Collaborator

baxgas commented Nov 20, 2019

It is indeed a bug in Gutenberg, but found this workaround

Although tedious, but simple (even for a non-developer), if you insert a gallery block and add gallery images and then set number of columns for block and set link to: "Attachments", you can then go to the block and "edit in html" and just replace the href=urls on each image with the link you want plus _target="blank" if you want to open in new tab, etc. For a small gallery, it is not too bad but they do need to fix this.

WordPress/gutenberg#8929 (comment)

@baxgas
Copy link
Collaborator

baxgas commented Nov 20, 2019

Unfortunately the WP editor is broken now (HTML code), adding new galleries can be done separately in a block, then appending the corrected html

@gammaw
Copy link
Member Author

gammaw commented Nov 23, 2019

Nice digging! Thanks for the workaround!

@gammaw gammaw closed this as completed Nov 23, 2019
@baxgas baxgas reopened this Apr 4, 2020
@baxgas
Copy link
Collaborator

baxgas commented Apr 4, 2020

Adding new gallery messed up the code again, I will automate it through javascript, that it happens automatically.

baxgas added a commit that referenced this issue Apr 5, 2020
baxgas added a commit that referenced this issue Apr 5, 2020
@gammaw gammaw assigned gammaw and unassigned baxgas Apr 19, 2020
gammaw added a commit that referenced this issue May 3, 2020
gammaw added a commit that referenced this issue May 3, 2020
@gammaw
Copy link
Member Author

gammaw commented May 3, 2020

Thanks, works like a charm! Tested, merged into master, branch closed, issue closed.

@butifarra
Copy link

Unfortunately the WP editor is broken now (HTML code), adding new galleries can be done separately in a block, then appending the corrected html

Hi! I have been searching a solution for days, but to no avail. It happened to me, I made it work, but the gallery in question, and any new galleries, are broken. I don´t grasp what you mean by "append the correct HTML", I am new to this. Can you explain more please? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants