Skip to content

Fix for issue #1 - return unexpected errors early #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

laher
Copy link
Owner

@laher laher commented May 24, 2021

this behaviour could potentially break someone's use of the library...

e.g. if they have one unreliable filesytem, this error might prevent you from ever reaching the correct filesystem.

Edit: I have provided one workaround:

  • mergefs.MergeWithOptions(mergefs.AllowError(my.TimeoutError))
  • If you want to permit certain errors, you can initialise mergefs with that kind of support.

It still doesn't feel quite right though. I'll think on it some more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant