Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): assets path on Windows #997

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(cli): assets path on Windows #997

merged 2 commits into from
Jun 27, 2023

Conversation

QuiiBz
Copy link
Member

@QuiiBz QuiiBz commented Jun 27, 2023

About

On Windows, the assets path includes a \\ delimiter instead of the expected / that is used when deploying, and when running lagon dev to return the correct asset instead of calling the function.

Example debug before:
Screenshot 2023-06-27 at 21 33 51

And after:
Screenshot 2023-06-27 at 21 34 45

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

🦋 Changeset detected

Latest commit: fc5889a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lagon/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 7:45pm
docs ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 7:45pm
storybook ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 7:45pm
www ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2023 7:45pm

@QuiiBz QuiiBz merged commit cfe19e6 into main Jun 27, 2023
@QuiiBz QuiiBz deleted the fix/cli-windows-path branch June 27, 2023 19:47
@QuiiBz QuiiBz mentioned this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant