-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime,serverless,cli): support CompressionStream & DecompressionStream APIs #932
Conversation
🦋 Changeset detectedLatest commit: 54c90f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@akitaSummer is attempting to deploy a commit to the Lagon Team on Vercel. A member of the Team first needs to authorize it. |
@QuiiBz This feature has been developed and there shouldn't be too many issues. If you have some free time, can you prioritize code review |
I've completely forgotten this PR, sorry. I'm currently on vacation so having a bit more time than usual, will review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR, and apologize for the late review!
I can't seem to run any of the tests locally. Could it be because of my Rust version?
|
You might need to rebuild the js-runtime package ( |
Thank you, the issue has been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
I've added some documentation, more tests and also fixed the implementation in this commit (tested the same JS code on Chrome & Safari to make sure it's now the correct result)
#425