-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runtime): support RSA-PSS, RSASSA-PKCS1-v1_5 & ECDSA for SubtleCrypto#sign
& SubtleCrypto#verify
#861
Conversation
🦋 Changeset detectedLatest commit: f310fab The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@akitaSummer is attempting to deploy a commit to the Lagon Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for the PR!
|
I pushed some fix (most notably #862), we now only have a single test failing (due to a timeout): crypto_rsa_pss_sign_verify ![]() |
Co-authored-by: Tom Lienard <[email protected]>
SubtleCrypto#sign
& SubtleCrypto#verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much!
Hello
I have implemented sign and verify functions for RSASSA-PKCS1-v1_5, RSA-PSS, and ECDSA, but only the test for ECDSA is passing. I suspect it may be due to the large size of Rust's vec, causing errors when converting to V8's ArrayBuffer. I suggest trying to find a solution to this issue, or perhaps using serde_v8's ZeroCopyBuf to refactor the project.
I have refactored the generateKey method to support all algorithms required by W3C, but I have not handled the extractable and keyUsages parameters. I hope you can address these when you have time.
I reviewed your importKey method and found that it does not comply with W3C standards. I suggest that you consider modifying it when you have the time.
Closes #408
Closes #407