Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): persist language choice #816

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

diboune
Copy link
Contributor

@diboune diboune commented Apr 30, 2023

About

Fixes #774

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2023

🦋 Changeset detected

Latest commit: 29e9157

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2023 9:37am
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2023 9:37am

@vercel
Copy link

vercel bot commented Apr 30, 2023

@diboune is attempting to deploy a commit to the Lagon Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I only have one comment:

Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention it in the initial review, but could you run pnpm changeset at the root for @lagon/dashboard as a patch? See https://docs.lagon.app/contributing#before-submitting-a-pr

Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@QuiiBz QuiiBz enabled auto-merge (squash) May 1, 2023 09:45
@QuiiBz QuiiBz merged commit 9f8d19b into lagonapp:main May 1, 2023
@QuiiBz QuiiBz mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferred language is not saved
2 participants