feat(serverless,cli): allow ending a stream before sending the response #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QuiiBz
force-pushed
the
feat/serverless-cli-allow-stream-end
branch
from
a0fcd5b to
f2b7ae5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
It's possible to have a stream done before the response is sent. This was already "supported": meaning it was working fine, but wrongly assumed that it was an error.
This PR properly handle this data -> done -> start streaming flow, and also handle errors if we get data when the stream is already done.
Also simplify the js-runtime streaming handling, not sure why it used a new
ReadableStreambecause it's 100% useless.