refactor(runtime): use macros for Rust <-> JS bindings #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Use two macros for Rust <-> JS bindings, instead of duplicating code (particularly with async bindings).
Now you can use
binding!()
for sync bindings, that take the same binding function as beforeasync_binding!()
for async bindings, which take a function to return the parsed args, and a second function that is async and returns aPromiseResult
. This last function is basically the future we created before.