Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js-runtime): make Headers class case insensitive #227

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

cyco130
Copy link
Contributor

@cyco130 cyco130 commented Nov 2, 2022

About

This PR makes the Headers class case insensitive, as required by the spec. Tests have been modified to cover case insensitivity. Fixes #226.

Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Two small suggestions:

@cyco130 cyco130 force-pushed the fix/headers-case-sensitivity branch from 6ff6a8f to 0efab5a Compare November 2, 2022 13:48
@QuiiBz QuiiBz changed the title Make Headers class case insensitive fix(js-runtime): make Headers class case insensitive Nov 2, 2022
Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! (I pushed c155054 to update a test in the Rust runtime)

@QuiiBz QuiiBz enabled auto-merge (squash) November 2, 2022 17:33
@QuiiBz QuiiBz merged commit bcf8530 into lagonapp:main Nov 2, 2022
@QuiiBz QuiiBz mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers API doesn't ignore case
2 participants