Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): update clap to v4 #159

Merged
merged 5 commits into from
Oct 3, 2022
Merged

feat(cli): update clap to v4 #159

merged 5 commits into from
Oct 3, 2022

Conversation

G3root
Copy link
Contributor

@G3root G3root commented Oct 1, 2022

About

fixes #157

QuiiBz
QuiiBz requested changes Oct 1, 2022
View reviewed changes
Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a wording change and we'll ready to merge/

@QuiiBz QuiiBz changed the title Update clap feat(cli): update clap to v4 Oct 1, 2022
@G3root G3root requested a review from QuiiBz October 3, 2022 04:07
QuiiBz
QuiiBz approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@QuiiBz QuiiBz merged commit cbf1778 into lagonapp:main Oct 3, 2022
@QuiiBz QuiiBz mentioned this pull request Oct 3, 2022
Merged
@G3root
Copy link
Contributor Author

G3root commented Oct 3, 2022

LGTM, thanks a lot!

open some good first issues, i'll help with some.

@G3root G3root deleted the update-clap branch October 3, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuiiBz QuiiBz QuiiBz approved these changes

Assignees
No one assigned
Labels
feature package/cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clap v4
2 participants
@G3root @QuiiBz