fix(runtime): avoid thread panicking when promise id not found (#624)

lagonapp · Feb 27, 2023 · 046d04f · 046d04f
1 parent 056aefa
commit 046d04f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/.changeset/lucky-cows-cross.md b/.changeset/lucky-cows-cross.md
@@ -0,0 +1,5 @@
+---
+'@lagon/runtime': patch
+---
+
+Avoid thread panicking when promise id is not found
diff --git a/crates/runtime_isolate/src/lib.rs b/crates/runtime_isolate/src/lib.rs
@@ -361,12 +361,9 @@ impl Isolate {
                 while let Poll::Ready(Some(BindingResult { id, result })) =
                     isolate_state.promises.poll_next_unpin(cx)
                 {
-                    let promise = isolate_state
-                        .js_promises
-                        .remove(&id)
-                        .unwrap_or_else(|| panic!("JS promise {id} not found"));
-
-                    promises.as_mut().unwrap().push((result, promise));
+                    if let Some(promise) = isolate_state.js_promises.remove(&id) {
+                        promises.as_mut().unwrap().push((result, promise));
+                    }
                 }
 
                 self.running_promises.store(false, Ordering::SeqCst);