Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set host header instead of host in url #515

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Set host header instead of host in url #515

merged 1 commit into from
Oct 28, 2020

Conversation

selaux
Copy link
Contributor

@selaux selaux commented Sep 25, 2018

Fixes #514

Set host header instead of host in url
de056d2 
Setting the host in the url might result in the request going
to a completely different server (wherever the hostname resolves
to), not necessarily the server under test.
@selaux selaux mentioned this pull request Sep 25, 2018
Closed
@coveralls
Copy link

coveralls commented Sep 25, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 338

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.309%
Totals Coverage Status
Change from base Build 330: 0.02%
Covered Lines: 138
Relevant Lines: 142
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 338

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 97.309%
Totals Coverage Status
Change from base Build 330: 0.02%
Covered Lines: 138
Relevant Lines: 142
💛 - Coveralls

@mszkwsk
Copy link

mszkwsk commented Jan 23, 2020

Hi guys!

Can you update me on the status of this PR? We'd love to have such feature implemented in supertest!

@vamsys
Copy link

vamsys commented Feb 17, 2020

Hi, can we have this merged? would help a lot.

@Austio
Copy link

Austio commented May 28, 2020

@niftylettuce Is there anything that i can do to help this PR become merged?

@niftylettuce
Copy link
Collaborator

The tests look botched in your PR, please fix them

@Va1
Copy link

Va1 commented Oct 12, 2020

please, let's get this merged. any updates on what's the status?

@niftylettuce
Copy link
Collaborator

I don't have access to supertest so I can't merge

@Va1
Copy link

Va1 commented Oct 13, 2020

@niftylettuce are you, perhaps, aware of someone who has access and is available?

@niftylettuce
Copy link
Collaborator

I emailed two people, waiting to hear back

@Va1
Copy link

Va1 commented Oct 14, 2020

@niftylettuce thank you!

@Va1
Copy link

Va1 commented Oct 28, 2020

@niftylettuce any news?

@niftylettuce
Copy link
Collaborator

I will reach out again

@niftylettuce niftylettuce merged commit 7114571 into ladjs:master Oct 28, 2020
@rimiti
Copy link
Contributor

rimiti commented Oct 28, 2020

@niftylettuce

I have just give you all accesses.
Thanks for your help 🙏

@niftylettuce
Copy link
Collaborator

niftylettuce commented Oct 28, 2020 •
edited
Loading

I am waiting on npm ownership, once I have that I will follow up. I think we'll do a minor major semver bump here unless you think otherwise.

@rimiti
Copy link
Contributor

rimiti commented Oct 28, 2020

I am waiting on npm ownership, once I have that I will follow up. I think we'll do a minor major semver bump here unless you think otherwise.

NPM access given.

@niftylettuce
Copy link
Collaborator

Released https://github.com/visionmedia/supertest/releases/tag/v6.0.0!

@Va1
Copy link

Va1 commented Oct 29, 2020

thank you guys @niftylettuce @rimiti much appreciated!

@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using .host method results in request not going to unit under test
8 participants
@selaux @coveralls @mszkwsk @vamsys @Austio @niftylettuce @Va1 @rimiti