Add simple digest auth implementation #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with Apache and passes tests. Does not implement all of RFC 2617 (for example, client nonces).
|
This feature would be really helpful |
|
FYI, mikeal/request has digest support. |
|
Would be great to get this merged! |
|
better handled as a plugin since we can't really support client and server with this. FWIW the request module is a behemoth and I don't think supporting everything it supports is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works with Apache and passes tests. Does not implement all of RFC 2617
(for example, client nonces).
Also, the fixes in #76 would be really nice to have, since this will not work if any redirects occur. I doubt that that patch will work as-is with my change, though.