-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vg.compat
forward-compatibilty layer for libraries
#158
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
52ac41c
Test using direct imports
paulmelnikow 0aafa3c
Add `vg.compat` compatibilty layer for libraries
paulmelnikow 41019da
+ test and fix
paulmelnikow 27fbf1b
+ note about deprecations
paulmelnikow bdd8480
Clarify this is for forward compatibility
paulmelnikow e2ac435
Merge branch 'main' into compat
paulmelnikow 1aee129
Add test for orient
paulmelnikow 788493e
Merge branch 'main' into compat
paulmelnikow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import numpy as np | ||
import pytest | ||
import vg.compat.v1 as vg | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
|
||
def test_v1_has_functions(): | ||
np.testing.assert_array_equal( | ||
vg.normalize(np.array([5, 0, 0])), np.array([1, 0, 0]) | ||
) | ||
|
||
|
||
def test_v1_has_constants(): | ||
np.testing.assert_array_equal(vg.basis.x, np.array([1, 0, 0])) | ||
|
||
|
||
def test_v1_orient_is_alias_for_aligned_with(): | ||
v1 = np.array([1.0, 2.0, 3.0]) | ||
with pytest.deprecated_call(): | ||
np.testing.assert_array_equal( | ||
vg.orient(v1, along=vg.basis.z), vg.aligned_with(v1, along=vg.basis.z) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
from ..core import * # noqa: F401, F403 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why drop all of this documentation from the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's duplicated from the documentation, and that seems like a better place for it: https://vgpy.dev/