Skip to content
This repository was archived by the owner on Feb 3, 2023. It is now read-only.

vectorize line intersection #7

Merged
merged 3 commits into from
Jun 30, 2017
Merged

Conversation

algrs
Copy link
Contributor

@algrs algrs commented Jun 29, 2017

No description provided.

@algrs algrs requested a review from eerac June 29, 2017 13:51
@algrs algrs mentioned this pull request Jun 29, 2017
@eerac
Copy link
Contributor

eerac commented Jun 30, 2017

Looks good to me, thanks for adding tests! I spent some time yesterday seeing if I could use batch insertion to speed up EdgeMap but it didn't really do anything and I wasn't able to do the same thing for Graph

@eerac
Copy link
Contributor

eerac commented Jun 30, 2017

Going forward my guess is that we should do some of the face/edge bookkeeping in the mesh class in advance so that the plane intersection code (which is called many, many times) can use a consistent representation of "edges" and which faces/vertices are associated with each edge. Note that this could be computed in advance for smpl template so it can be relatively involved to construct as long as it has a clean interface

@algrs
Copy link
Contributor Author

algrs commented Jun 30, 2017

Totally makes sense. I do think for the particular application we're focused on speeding up here we're closing in on the gains it's worth pursuing here and we should shift our attention to the side of the algorithm in the private side of the project.

@algrs algrs merged commit 49c3ecd into master Jun 30, 2017
@algrs algrs deleted the 129_vectorize_line_intersection branch June 30, 2017 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants