Fix threading issues in auto-threshold code #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes the bug where not selecting a channel names csv file in the front end caused an unexpected exception on windows. Now the code explicitly checks that the csv path exists and is not a directory rather than relying on exceptions (as the particular IO exceptions raised in some circumstances do vary by platform). |
Previous implementation deadlocked on Windows. This change fixes that and cleans up the code in general. Now uses ThreadPoolExecutor instead of explicitly launching Threads. Even after the general cleanups I was encountering deadlocks in np.dot on normal numpy arrays in a threaded context -- switching to the "blis" BLAS implementation fixed that (requirements.yml now contains an entry for this).
jmuhlich
force-pushed
the
auto-threshold-threads
branch
from
341dbeb to
b5cecaa
Compare
thejohnhoffer
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation deadlocked on Windows. This change fixes that and cleans up the code in general. Now uses ThreadPoolExecutor instead of explicitly launching Threads. Even after the general cleanups I was encountering deadlocks in np.dot on normal numpy arrays in a threaded context -- switching to the "blis" BLAS implementation fixed that (requirements.yml now contains an entry for this).