Fix wrong status code returning in case of handler with middleware.Timeout throws the panic #1864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that when the
echo.HandlerFunc
withmiddleware.Timeout
callspanic
, globalmiddleware.Recover()
could return a wrong status code to the client, cause insideechoHandlerFuncWrapper.ServeHTTP
method theoriginalWriter
wasn't restored if handler throws the panic.This pull request must fix this issue.