implementaion for sealos exec #429 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldthreefeng
commented
Sep 3, 2020
| Cmd string | ||
| Label string | ||
| // map["hostname"] -> ip | ||
| Nodes map[string]string |
There was a problem hiding this comment.
其实这里很想重写 nodeips 和masterips.
在里面有ip , port , hostname 等属性, 直接在init的时候就保存在sealos的文件里面.
很多时候有需要用到hostname.
There was a problem hiding this comment.
有一定道理 定义一个Server的结构体，这个我之前考虑过，重构的东西可以放到后面的大版本中去。 有4.0的计划
|
need test for mutli nodes .. |
|
还没写完， 里面的一些debug信息还没去除。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SKIP CI]seaols: 一句话简短描述该PR内容
stage