fix: Make the merged checksum file available to the installer #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/ai/backend/install/context.py:1025
- [nitpick] The error message could be more informative by including the actual URL of the checksum file.
raise ValueError(f"Checksum for {pkg_name} not found in {csum_path}")
Comment on lines
+1009
to
1011
| async with self.wget_sema: | ||
| await wget(csum_url, dst_path, progress) | ||
|
|
There was a problem hiding this comment.
The download of the checksum file should handle potential errors to avoid issues if the download fails.
Suggested change
| async with self.wget_sema: | |
| await wget(csum_url, dst_path, progress) | |
| try: | |
| async with self.wget_sema: | |
| await wget(csum_url, dst_path, progress) | |
| except (aiohttp.ClientError, asyncio.TimeoutError) as e: | |
| self.log.write(f"Failed to download {csum_url}: {e}") | |
| raise RuntimeError(f"Failed to download checksum file from {csum_url}. Please check your network connection and try again.") |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
fix.md -> 3597.fix.md Co-authored-by: octodog <[email protected]>
HyeockJinKim
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3575 (BA-635)
The checksum files have been consolidated into one.
The installer changes from downloading the checksum files for each package separately to receiving a consolidated checksum file and using them separately.
Checklist: (if applicable)