refactor(BA-589): Apply pydantic handling decorator to VFolder APIs in storage-proxy (#3562) #3565
+618
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:docs
MintCat98
force-pushed
the
refactor/apply-decorator
branch
from
efcd288 to
5475cce
Compare
MintCat98
changed the base branch from
main
to
feat/add-pydantic-handling-decorator-for-req-res
MintCat98
changed the title
|
I wrote down wrong Jira number in commit messages. |
HyeockJinKim
reviewed
Feb 4, 2025
Comment on lines
+1
to
+25
| # import uuid | ||
| # from pathlib import Path | ||
| # from unittest.mock import AsyncMock | ||
|
|
||
| # import pytest | ||
| # from aiohttp import web | ||
|
|
||
| # from ai.backend.common.types import BinarySize, QuotaConfig, QuotaScopeID, QuotaScopeType, VFolderID | ||
| # from ai.backend.storage.api.vfolder.manager_handler import VFolderHandler | ||
| # from ai.backend.storage.api.vfolder.response_model import ( | ||
| # GetVolumeResponseModel, | ||
| # NoContentResponseModel, | ||
| # ProcessingResponseModel, | ||
| # QuotaScopeResponseModel, | ||
| # VFolderMetadataResponseModel, | ||
| # ) | ||
| # from ai.backend.storage.api.vfolder.types import ( | ||
| # QuotaScopeIDModel, | ||
| # QuotaScopeMetadataModel, | ||
| # VFolderIDModel, | ||
| # VFolderMetadataModel, | ||
| # VolumeIDModel, | ||
| # VolumeMetadataListModel, | ||
| # VolumeMetadataModel, | ||
| # ) |
There was a problem hiding this comment.
Why are all the test codes set as comments?
There was a problem hiding this comment.
I haven’t yet modified the necessary parts of the test code due to the decorator update, which is causing continuous errors, so I temporarily commented it out as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3562 (BA-589)
Applied pydantic decorator to vfolder APIs in sotrage-proxy.
Tests are not done yet.
Checklist: (if applicable)
ai.backend.testdocsdirectory📚 Documentation preview 📚: https://sorna--3565.org.readthedocs.build/en/3565/
📚 Documentation preview 📚: https://sorna-ko--3565.org.readthedocs.build/ko/3565/