Feat/jazzkeys keys config #143
Merged
+68
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the four jazzkeys to the config file and uses them to make changes in the velocity and octave when in jazzkeys mode.
It works better if the changes only occur once per key press.
|
Thanks! The config stuff is a good addition. If repeating keys are a problem. would it be simpler to just check for the "repeat" variable in the triggering input event or use SDL_Keyup (that might feel a little weird though)? https://wiki.libsdl.org/SDL2/SDL_KeyboardEvent |
This is much simpler than the previous implementation with custom variables used as semaphors.
|
Yes, much simpler! I don't know much about SDL2 and didn't know about the repeat in the event, thanks for pointing it out. I have added a refactor commit that skips the repeat and key up to avoid the issue when holding the key. |
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should allow to set the jazzkeys keys in the config. It also has a fix for an issue I had after doing the changes, where the velocity/octaves were changing if holding the key, which made it difficult to use because it was skipping the values too fast.
@laamaa Can you take a look and see if it works ok for you? I tried to keep the previous numpad keys as the default in the config.
I think the readme could be updated if merging this feature.
Thanks!