Graceful restart for l3afd #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atul-source
changed the title
Atul-source
requested review from
sanfern,
charleskbliu0,
jniesz,
dthaler,
ajayR006,
dalalkaran and
pmoroney
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sanfern
requested changes
Aug 25, 2024
pmoroney
requested changes
Aug 27, 2024
| // @Param cfgs body []models.L3afBPFPrograms true "BPF programs" | ||
| // @Success 200 | ||
| // @Router /l3af/configs/v1/restart [put] | ||
| func HandleRestart(bpfcfg *bpfprogs.NFConfigs) http.HandlerFunc { |
There was a problem hiding this comment.
Should this endpoint be authenticated or anything? Is that handled elsewhere?
Atul-source
force-pushed
the
graceful-restart
branch
from
e5e71e5 to
4645f1e
Compare
Atul-source
force-pushed
the
graceful-restart
branch
3 times, most recently
from
78ab85d to
7b73b40
Compare
sanfern
requested changes
Sep 3, 2024
Atul-source
force-pushed
the
graceful-restart
branch
3 times, most recently
from
cb54123 to
0ca2c36
Compare
Atul-source
force-pushed
the
graceful-restart
branch
2 times, most recently
from
971031e to
4e2e20c
Compare
Atul-source
force-pushed
the
graceful-restart
branch
2 times, most recently
from
656c654 to
5b07cb2
Compare
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Signed-off-by: Atul-source <[email protected]>
Atul-source
force-pushed
the
graceful-restart
branch
from
4927af2 to
56197ca
Compare
sanfern
requested changes
Sep 17, 2024
Signed-off-by: Atul-source <[email protected]>
Atul-source
force-pushed
the
graceful-restart
branch
from
56197ca to
2aaf805
Compare
Signed-off-by: Atul-source <[email protected]>
Atul-source
force-pushed
the
graceful-restart
branch
from
2ec2817 to
ed652c1
Compare
pmoroney
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have implemented graceful restart of l3afd means upgrading/restarting the l3afd without affecting ebpf programs state and having same level of control on eBPF programs as we were having on old instance.
This PR is dependent on
l3af-project/eBPF-Package-Repository#92
l3af-project/l3af-arch#124